Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(semgrep): running additional test to confirm semgrep cleanup #61

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

pkanoongo
Copy link
Contributor

@pkanoongo pkanoongo commented Jan 15, 2025

Description:
This PR adds a cleanup step to the semgrep workflow to remove residual files and direcotry created during semgrep scans. This ensures a clean runner environment, preventing any blocker for follow-up scans or workflows.

Changes:
/static-analysis/action.yaml.

Copy link

Release notes preview

Below is a preview of the release notes if your PR gets merged.


3.1.2 (2025-01-15)

Bug Fixes

  • semgrep: adding cleanup process (9884636)
  • semgrep: adding cleanup process (81d3a75)
  • semgrep: adding just the cleanup process (466b3e1)
  • semgrep: running additional test to confirm semgrep cleanup (2b95bd1)

Miscellaneous

  • deps: update lacework/lw-scanner-action action to v1.4.4 (afd3048)
  • deps: update node.js to v22.13.0 (3322604)

@pkanoongo pkanoongo marked this pull request as ready for review January 16, 2025 04:11
@pkanoongo pkanoongo requested a review from a team as a code owner January 16, 2025 04:11
Copy link
Contributor

@prathamesh16c prathamesh16c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pkanoongo need to rebase as #60 was added a few days ago.

We should hold off on this until we decide on making python version deterministic or not. Depending on that not sure if residual files left on the runners will change, but would be good to know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants