Skip to content

fix(utils): save config #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 25, 2025
Merged

fix(utils): save config #578

merged 5 commits into from
Apr 25, 2025

Conversation

LuciNyan
Copy link
Contributor

@LuciNyan LuciNyan commented Apr 23, 2025

Description

When saveConfig is called, the project doc is incorrectly saved into user instructions. This change ensures that only user instructions are saved to instructions.md during saveConfig, preventing data corruption.

close: #576

Copy link

github-actions bot commented Apr 23, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@LuciNyan
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@LuciNyan
Copy link
Contributor Author

recheck

github-actions bot added a commit that referenced this pull request Apr 23, 2025
@LuciNyan LuciNyan changed the title fix: instructions save [WIP]fix: instructions save Apr 23, 2025
@LuciNyan LuciNyan changed the title [WIP]fix: instructions save fix: save config Apr 23, 2025
@LuciNyan LuciNyan force-pushed the fix-config-save branch 2 times, most recently from 89a5260 to 335f3f5 Compare April 23, 2025 09:50
@LuciNyan LuciNyan changed the title fix: save config [wip]fix: save config Apr 23, 2025
@LuciNyan LuciNyan changed the title [wip]fix: save config fix: save config Apr 23, 2025
@LuciNyan LuciNyan changed the title fix: save config fix(utils): save config Apr 24, 2025
@tibo-openai
Copy link
Collaborator

Nice one, thank you for contributing this fix. It looks like there are CI failures for formatting

> @openai/codex@0.1.2504221401 format /home/runner/work/codex/codex/codex-cli
> prettier --check src tests

Checking formatting...
[warn] src/utils/config.ts
[warn] Code style issues found in the above file. Forgot to run Prettier?
 ELIFECYCLE  Command failed with exit code 1.

could you take a look and once resolved then I will merge.

@LuciNyan
Copy link
Contributor Author

LuciNyan commented Apr 24, 2025

Hi @tibo-openai 👋 Thank you for the feedback! I’ve resolved the Prettier formatting issues.

However, I noticed that the current lint-staged configuration on the main branch has an issue that is blocking most commits. Could you please take a look at the details here: #617?

@tibo-openai
Copy link
Collaborator

Merged #617, thank you!

@tibo-openai
Copy link
Collaborator

Simplified the code a bit. Thank you for the contribution!

@tibo-openai tibo-openai merged commit c38c2a5 into openai:main Apr 25, 2025
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2025
@LuciNyan LuciNyan deleted the fix-config-save branch April 25, 2025 02:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

text from project root codex.md gets appended into .codex/instructions.md on every session
2 participants