Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement #14 Agents should query the ResourceType they're carrying #31

Merged
merged 5 commits into from
Feb 18, 2024
Merged

Implement #14 Agents should query the ResourceType they're carrying #31

merged 5 commits into from
Feb 18, 2024

Conversation

tommy33790
Copy link
Contributor

📜 Description

Changes proposed in this pull request:

  • Added AgentInterface.carryingResourceType: ResourceType

✅ Checklist:

  • Created tests which fail without the change (if possible) => Framework not yet implemented
  • Extended the documentation (if necessary)

@tommy33790 tommy33790 linked an issue Feb 12, 2024 that may be closed by this pull request
Agents should query the ResourceType they're carrying #14
Closed
@DivineThreepwood
Copy link
Member

Was already implemented by isCarringResourc(X).
Do you think that this is then still an improvement?

@DivineThreepwood DivineThreepwood marked this pull request as draft February 18, 2024 21:52
auto-merge was automatically disabled February 18, 2024 21:52

Pull request was converted to draft

@DivineThreepwood DivineThreepwood marked this pull request as ready for review February 18, 2024 21:52
@DivineThreepwood DivineThreepwood merged commit b0ba680 into dev Feb 18, 2024
2 checks passed
@DivineThreepwood DivineThreepwood deleted the feature/#14_agents_query_resourcetype branch February 18, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DivineThreepwood DivineThreepwood DivineThreepwood approved these changes

Assignees

@tommy33790 tommy33790

Labels
code-approved tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Agents should query the ResourceType they're carrying
2 participants
@tommy33790 @DivineThreepwood