tests: fix failures on SELinux-enabled systems #609
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #609 +/- ##
==========================================
+ Coverage 73.68% 73.74% +0.05%
==========================================
Files 69 69
Lines 5556 5557 +1
==========================================
+ Hits 4094 4098 +4
+ Misses 1074 1072 -2
+ Partials 388 387 -1 🚀 New features to boost your workflow:
|
|
It would be nice to add CirrusCI for AlmaLinux tests (like runc does) but I cannot enable the CirrusCI app on this repo... @estesp Do you know who to ping to click "install" on this configuration page for the umoci repo? Also it would be nice for you to install the CodeCov app as well (see the above errors)! |
I'm checking who has "admin" at the organizational level; apparently I don't :) |
Our tests would incorrectly treat security.selinux like a regular xattr, which lead to failures because it gets auto-set on all new files. The solution is quite simple -- just include any such xattrs in expected sets (or filter them out) before doing checks in our tests. umoci itself still handle security.selinux fine (we emulate it using a fake user xattr), this is just a bug in our tests' handling of security.selinux. Fixes: 6fd1e0e ("oci: ignore system.nfs4_acl and extend forbidden-xattr handling") Fixes: 9a1cefa ("oci: layer: correctly handle trusted.overlay xattr namespace escaping") Fixes: 54f34c9 ("oci: layer: refix auto-applied xattr handling") Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
cyphar
force-pushed
the
xattr-selinux
branch
from
0d60229 to
df3a23e
Compare
Our tests would incorrectly treat security.selinux like a regular xattr,
which lead to failures because it gets auto-set on all new files. The
solution is quite simple -- just include any such xattrs in expected
sets (or filter them out) before doing checks in our tests.
umoci itself still handle security.selinux fine (we emulate it using a
fake user xattr), this is just a bug in our tests' handling of
security.selinux.
Fixes #605
Fixes: 6fd1e0e ("oci: ignore system.nfs4_acl and extend forbidden-xattr handling")
Fixes: 9a1cefa ("oci: layer: correctly handle trusted.overlay xattr namespace escaping")
Fixes: 54f34c9 ("oci: layer: refix auto-applied xattr handling")
Signed-off-by: Aleksa Sarai cyphar@cyphar.com