Fix declaration of ica_aes_gcm_kma_ctx_new in ica_api.h header #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building an application that includes ica_api.h with -Wstrict-prototypes, then this shows warnings/errors for the ica_aes_gcm_kma_ctx_new() declaration in ica_api.h. The declaration in ica_api.h is anyway different that the one used in ica_api.c: ica_api.h: ICA_EXPORT kma_ctx* ica_aes_gcm_kma_ctx_new(); ica_api.c: kma_ctx* ica_aes_gcm_kma_ctx_new(void) Signed-off-by: Ingo Franzki <ifranzki@linux.ibm.com>
jschmidb
approved these changes
Apr 28, 2025
|
It was the only place in the external header file. Inside libica code there are more places with empty arguments functions. As long as libica itself is not built with |
|
@jschmidb do you want to merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building an application that includes ica_api.h with -Wstrict-prototypes, then this shows warnings/errors for the ica_aes_gcm_kma_ctx_new() declaration in ica_api.h.
The declaration in ica_api.h is anyway different that the one used in ica_api.c:
ica_api.h:
ica_api.c:
kma_ctx* ica_aes_gcm_kma_ctx_new(void)