Fix issue #68: fix weird extra space in game cards #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of this stuff up so it's easier to manage.
Auto-width fucks up the card heights, so get rid of that shit. Not sure how it actually causes the issue, best guess is it's doing something with image widths, getting biggest, and scaling the cards vertically so the widest image is full-width prior to cropping to 25% width for the card itself? Whatever the case, it was pretty fucking bad. For the breakpoint stuff, just trying to make the images less likely to fight for space with the text content at smaller screen sizes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves #68 by adjusting the calculations for card image heights and widths.
Additionally, it pulls out a fair bit of SCSS source into separate files for easier management in case of future styling work.