Update #169
Merged
Update #169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludomal
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request to fix the issue #167
These are the updates:
Further, two test cases have been added to test the RMS scaling feature. The output tolerance is set using the BS.2217 tolerance of +/- 0.1 dB LKFS. The manual has also been updated to document the feature.
The plan is to use the updated tool in the upcoming 3GPP IVAS selection tests and it is proposed to update the official STL tool set with these features as well. Note that the output is the same when not using the -rms option. The only difference is the error handling for low level signals with all blocks below -70 LKFS. The existing version reports a level of "nan", while the update now outputs a more verbose warning.