8366264: tools/javac/launcher/SourceLauncherStackTraceTest.java does not cover the scenario for 8362237

[liach]

In #26601, I moved a test case to create a traceless exception for the source launcher that depended on C2 behaviors to a separate test with compiler flags. However, that move is incorrect: to reproduce the issue, the cause exception must have no trace while the InvocationTargetException does. My migrated test blindly turned off stack traces for all exceptions, which is not the intended scenario.

I found that in Java 7, Throwable, Exception, Error, and RuntimeException get new constructors that allow specifying suppression and trace filling behaviors. We can use that constructor to prohibit stack traces for the cause while preserving the trace for the InvocationTargetException.

Testing: Running the single source file on Java 24 and getting the array copy IAE (ensure it is a valid reproducer), and running the test to ensure the new case passes.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8366264: tools/javac/launcher/SourceLauncherStackTraceTest.java does not cover the scenario for 8362237 (Bug - P4)

Reviewers

• Christian Stein (@sormuras - Committer)
• Jan Lahoda (@lahodaj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26993/head:pull/26993
$ git checkout pull/26993

Update a local copy of the PR:
$ git checkout pull/26993
$ git pull https://git.openjdk.org/jdk.git pull/26993/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26993

View PR using the GUI difftool:
$ git pr show -t 26993

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26993.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back liach! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@liach This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8366264: tools/javac/launcher/SourceLauncherStackTraceTest.java does not cover the scenario for 8362237

Reviewed-by: cstein, jlahoda

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

• 849570a: 8365288: PEMDecoder should throw ClassCastException
• d594ef3: 8366121: Hotspot Style Guide should document conventions for lock-free code
• ae96077: 8361614: Missing sub-int value validation in the Class-File API
• ... and 7 more: https://git.openjdk.org/jdk/compare/33d00a77f38ea16e4751b216a3bf98a620eb8055...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@liach The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (997ee320)

[lahodaj]

Looks sensible to me. Please be sure to run tests before integrating.

[liach]

Please be sure to run tests before integrating.

Is there any test I should run besides the tools/javac/launcher/SourceLauncherTest.java?

[liach]

Since I cannot think of other tests to run and the revised SourceLauncherTest passes on CI against 26 build 13, I think we are fine. Thanks for the reviews.

/integrate

[openjdk]

Going to push as commit 0e73993.
Since your change was applied there have been 12 commits pushed to the master branch:

• f23c150: 8366359: Test should throw SkippedException when there is no lpstat
• d4ce630: 8366399: Allow custom base reference for update_copyright_year.sh
• 849570a: 8365288: PEMDecoder should throw ClassCastException
• ... and 9 more: https://git.openjdk.org/jdk/compare/33d00a77f38ea16e4751b216a3bf98a620eb8055...master

Your commit was automatically rebased without conflicts.

[openjdk]

@liach Pushed as commit 0e73993.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.