8366208: Unexpected exception in sun.java2d.cmm.lcms.LCMSImageLayout

[mrserb]

We have a few places in the cmm code where the fast-code-path assumes that standard buffered images with type such as TYPE_INT_ARGB_PRE use our private raster implementation such as IntegerComponentRaster, which is not necessarily true. Casting to these private raster types can result in a ClassCastException.

The patch will detect such custom images and fall back to the slow path for conversion.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8366208: Unexpected exception in sun.java2d.cmm.lcms.LCMSImageLayout (Bug - P3)

Reviewers

• Alexey Ivanov (@aivanov-jdk - Reviewer)
• Phil Race (@prrace - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26994/head:pull/26994
$ git checkout pull/26994

Update a local copy of the PR:
$ git checkout pull/26994
$ git pull https://git.openjdk.org/jdk.git pull/26994/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26994

View PR using the GUI difftool:
$ git pr show -t 26994

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26994.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8366208: Unexpected exception in sun.java2d.cmm.lcms.LCMSImageLayout

Reviewed-by: aivanov, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 42 new commits pushed to the master branch:

• 849570a: 8365288: PEMDecoder should throw ClassCastException
• d594ef3: 8366121: Hotspot Style Guide should document conventions for lock-free code
• ae96077: 8361614: Missing sub-int value validation in the Class-File API
• ... and 39 more: https://git.openjdk.org/jdk/compare/1aca920f5987399dbd114fd5e62b26b363363e64...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@mrserb The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (83c4c62b)
• 01: Full - Incremental (a7f3aa28)
• 00: Full (abf0ac30)

[aivanov-jdk]

Overall, looks good to me except for a couple minor comments.

Without the fix, the test throws ClassCastException, doesn't it?

[mrserb]

Without the fix, the test throws ClassCastException, doesn't it?

Yes, like this: ClassCastException: CustomRaster cannot be cast to class IntegerComponentRaster

[mrserb]

/integrate

[openjdk]

Going to push as commit 12e6a0b.
Since your change was applied there have been 45 commits pushed to the master branch:

• 0e73993: 8366264: tools/javac/launcher/SourceLauncherStackTraceTest.java does not cover the scenario for 8362237
• f23c150: 8366359: Test should throw SkippedException when there is no lpstat
• d4ce630: 8366399: Allow custom base reference for update_copyright_year.sh
• ... and 42 more: https://git.openjdk.org/jdk/compare/1aca920f5987399dbd114fd5e62b26b363363e64...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mrserb Pushed as commit 12e6a0b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.