feat: Node.js Middleware support #3018
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Package size report 0.4%↑
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
pieh
force-pushed
the
feat/node-middleware-support
branch
from
308acfe to
2031077
Compare
pieh
force-pushed
the
feat/node-middleware-support
branch
from
87ddbe5 to
91bb19d
Compare
…nt to specific modules
…uter with i18n enabled fails to build on next@canary now
…lity of crypto, path and http(s) node.js builtins
… modules are attempted in node middleware
pieh
force-pushed
the
feat/node-middleware-support
branch
from
a9c05bb to
57e8166
Compare
pieh
changed the title
…ll checking that .node and bcrypt is mentioned in error message
pieh
commented
Aug 25, 2025
| @@ -101,7 +105,7 @@ export async function getMockedRequestHandler(...args: Parameters<typeof getRequ | |||
| // only try to get .html files from the blob store | |||
| if (typeof path === 'string' && path.endsWith('.html')) { | |||
| const cacheStore = getMemoizedKeyValueStoreBackedByRegionalBlobStore() | |||
| const relPath = relative(resolve('.next/server/pages'), path) | |||
| const relPath = relative(resolve(nextConfig.distDir, 'server/pages'), path) | |||
There was a problem hiding this comment.
not related to Node.js Middleware support, but this fixes serving static files if non-default distDir is used (test setup for Node.js middleware variants is hitting those conditions)
pieh
added
the
test all versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for Node.js Middleware support.
Important notes:
.nodemodules (C++ Addons) - the only way to load them are from disk, as internally this relies on ~dllopenkind of native functions, so we can't simulate them in Deno/~Node.js runtimeDocumentation
Tests
test-variants.jsonfiles that builds existing fixtures in 2 variants and then integration/e2e tests running both of them):next buildwas failing with them so that was just Next.js not building them at all for Node.js variant and not the case of just missing support for themnode:crypto,node:path,node:http(s)) working that was not possible to do with Edge middleware.nodemodules