Skip to content

Remove Circuit Breaker check from File Cache put and compute #19135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Remove Circuit Breaker check from File Cache put and compute #19135

wants to merge 5 commits into from

Conversation

Gagan6164
Copy link
Contributor

@Gagan6164 Gagan6164 commented Aug 24, 2025 •
edited
Loading

Description

Remove Circuit Breaker check from File Cache put and compute

Related Issues

Resolves #19137

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Remove Circuit Breaker check from File Cache put and compute
1c5a01d 
Signed-off-by: Gagan Singh Saini <gagasa@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 1c5a01d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Apply Spotless fix
9e02c05 
Signed-off-by: Gagan Singh Saini <gagasa@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 9e02c05: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Minot test fix
a5140f4 
Signed-off-by: Gagan Singh Saini <gagasa@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for a5140f4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Minot test fix 2
2e35bd0 
Signed-off-by: Gagan Singh Saini <gagasa@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 2e35bd0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kkewwei
Copy link
Contributor

kkewwei commented Aug 25, 2025 •
edited
Loading

Could you describe the reason for the PR?

Spotless apply
9360d12 
Signed-off-by: Gagan Singh Saini <gagasa@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 9360d12: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Aug 25, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.83%. Comparing base (9e64838) to head (9360d12).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #19135      +/-   ##
============================================
- Coverage     72.91%   72.83%   -0.09%     
+ Complexity    69478    69413      -65     
============================================
  Files          5648     5648              
  Lines        319272   319261      -11     
  Branches      46183    46183              
============================================
- Hits         232811   232531     -280     
- Misses        67641    67947     +306     
+ Partials      18820    18783      -37

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request Search:Searchable Snapshots labels Aug 25, 2025
@Gagan6164
Copy link
Contributor Author

Could you describe the reason for the PR?

@kkewwei I have created an issue describing the motivation behind this change.

rayshrey
rayshrey reviewed Aug 25, 2025
View reviewed changes
server/src/main/java/org/opensearch/index/store/remote/filecache/FileCache.java
private final CircuitBreaker circuitBreaker;

public FileCache(SegmentedCache<Path, CachedIndexInput> cache, CircuitBreaker circuitBreaker) {
public FileCache(SegmentedCache<Path, CachedIndexInput> cache) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since FileCache is annotated as a Public API, this would be a breaking change.
Can we add a new constructor instead and call this constructor with a NoOpCircuitBreaker as the default ?

@Gagan6164 Gagan6164 force-pushed the removeCircuitBreakerInFileCache branch from 4fffb63 to 9360d12 Compare August 26, 2025 04:47
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 9360d12: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Aug 26, 2025
Open
@Gagan6164 Gagan6164 closed this Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@cwperks cwperks Awaiting requested review from cwperks cwperks is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah

1 more reviewer

@rayshrey rayshrey rayshrey left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
enhancement Enhancement or improvement to existing feature or request Search:Searchable Snapshots
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC] Remove Circuit Breaker check from File Cache
3 participants
@Gagan6164 @kkewwei @rayshrey