Using Scripted Avg Class in AvgAggregationBuilder in place of double #1460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tandonks
requested review from
bowenlan-amzn,
Hailong-am,
vikasvb90,
shiv0408 and
soosinha
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1460 +/- ##
=======================================
Coverage 76.17% 76.17%
=======================================
Files 375 375
Lines 18773 18773
Branches 2366 2366
=======================================
Hits 14300 14300
+ Misses 3237 3236 -1
- Partials 1236 1237 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Kshitij Tandon <tandonks@amazon.com>
tandonks
force-pushed
the
tandonks-Avg
branch
from
1ec951a to
c33af62
Compare
soosinha
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses ScriptedAvg class for AvgAggregationBuilder in place of double, so that it can be handled gracefully during reduce
Related PRs in OpenSearch: opensearch-project/OpenSearch#18411
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.