Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix midstream patches #1089

Merged

Conversation

dsimansk
Copy link

@dsimansk dsimansk commented Jan 15, 2025

  • Fix grpc tests patch after changes
  • Fix app protocol patch
    /cc @skonto

@openshift-ci openshift-ci bot requested a review from skonto January 15, 2025 10:19
@dsimansk dsimansk changed the title Fix grpc tests patch after changes Fix midstream patches Jan 15, 2025
@skonto
Copy link

skonto commented Jan 15, 2025

/lgtm
/approve

Copy link

openshift-ci bot commented Jan 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit fc67f5c into openshift-knative:main Jan 15, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants