-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .ci-operator.yaml, upgrade pip3 #34
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fe4c657
to
9abd7ac
Compare
9abd7ac
to
c7fd092
Compare
Containerfile
Outdated
# Install ansible and ansible-lint | ||
RUN pip3 install --no-cache-dir \ | ||
setuptools_rust \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can remove setuptools_rust
as it should be installed as other dependencies
Containerfile
Outdated
@@ -6,8 +6,12 @@ RUN dnf -y install \ | |||
python3-pip \ | |||
&& dnf clean all | |||
|
|||
# Upgrade pip3 | |||
RUN pip3 install --upgrade pip | |||
|
|||
# Install ansible and ansible-lint | |||
RUN pip3 install --no-cache-dir \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can reduce RUN
steps by doing something like this
RUN pip3 install --no-cache-dir \ | |
RUN pip3 install --upgrade pip && \ | |
pip3 install --no-cache-dir \ |
Is this PR title still relevant? I think we can change it |
8c4385f
to
9cc51fb
Compare
9cc51fb
to
c69d5be
Compare
410ef41
to
3992632
Compare
@shaior: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
No description provided.