Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .ci-operator.yaml, upgrade pip3 #34

Closed
wants to merge 4 commits into from

Conversation

shaior
Copy link
Contributor

@shaior shaior commented Jan 27, 2025

No description provided.

@openshift-ci openshift-ci bot requested review from ccardenosa and kononovn January 27, 2025 15:13
Copy link

openshift-ci bot commented Jan 27, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from shaior. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shaior shaior force-pushed the adding_setuptools_rust branch 2 times, most recently from fe4c657 to 9abd7ac Compare January 27, 2025 15:54
@shaior shaior force-pushed the adding_setuptools_rust branch from 9abd7ac to c7fd092 Compare January 28, 2025 09:16
Containerfile Outdated
# Install ansible and ansible-lint
RUN pip3 install --no-cache-dir \
setuptools_rust \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove setuptools_rust as it should be installed as other dependencies

Containerfile Outdated
@@ -6,8 +6,12 @@ RUN dnf -y install \
python3-pip \
&& dnf clean all

# Upgrade pip3
RUN pip3 install --upgrade pip

# Install ansible and ansible-lint
RUN pip3 install --no-cache-dir \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can reduce RUN steps by doing something like this

Suggested change
RUN pip3 install --no-cache-dir \
RUN pip3 install --upgrade pip && \
pip3 install --no-cache-dir \

@natifridman
Copy link
Collaborator

Is this PR title still relevant? I think we can change it

@shaior shaior force-pushed the adding_setuptools_rust branch from 8c4385f to 9cc51fb Compare January 28, 2025 09:41
@shaior shaior force-pushed the adding_setuptools_rust branch from 9cc51fb to c69d5be Compare January 28, 2025 09:44
@shaior shaior changed the title Add setuptools_rust Add .ci-operator.yaml, upgrade pip3 Jan 28, 2025
@shaior shaior force-pushed the adding_setuptools_rust branch from 410ef41 to 3992632 Compare January 28, 2025 11:48
Copy link

openshift-ci bot commented Jan 28, 2025

@shaior: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 3992632 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@shaior shaior closed this Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants