added role ocp_operator_deployment and playbook deploy-ocp-operators #52
Conversation
kononovn
force-pushed
the
ocp_operator_deployment
branch
6 times, most recently
from
fb53a82 to
e63e58b
Compare
| @@ -0,0 +1,3 @@ | |||
| - name: Todo - Brew | |||
There was a problem hiding this comment.
I believe we should merge this once its set up.
| install_approval: "{{ item.install_approval | default('Automatic') }}" | ||
| kubeconfig: /home/telcov10n/project/generated/kni-qe-92/auth/kubeconfig | ||
|
|
||
| - name: Apply default operator configuration if exist |
There was a problem hiding this comment.
Is this task installing operators that have templates, regardless of whether they are needed?
There was a problem hiding this comment.
Well this task starts operator on cluster Without operator's configuration we have only operator's pod running. Refer for more info:
https://docs.openshift.com/container-platform/4.17/networking/networking_operators/sr-iov-operator/installing-sriov-operator.html#install-operator-cli_installing-sriov-operator Step 4
https://docs.openshift.com/container-platform/4.10/networking/metallb/metallb-operator-install.html#nw-metallb-operator-initial-config_metallb-operator-install
This actually deploy some 'hardcoded' resource that are required in order to lauch operators on cluster.
There was a problem hiding this comment.
I think that if we want to make this role generic, we should make this step optional
There was a problem hiding this comment.
Added deploy_default_config parameter.
playbooks/roles/ocp_operator_deployment/tasks/deploy_operator.yaml
Outdated
Show resolved
Hide resolved
| --- | ||
| # defaults file for ocp_operator_deployment | ||
| ocp_operator_deployment_default_label: | ||
| workload.openshift.io/allowed: management |
There was a problem hiding this comment.
Do we always need this label or just in specific cases?
There was a problem hiding this comment.
As far as I see yes it's like an default label.
kononovn
force-pushed
the
ocp_operator_deployment
branch
from
e63e58b to
e8ee688
Compare
|
lgtm |
kononovn
force-pushed
the
ocp_operator_deployment
branch
from
e8ee688 to
985926e
Compare
kononovn
force-pushed
the
ocp_operator_deployment
branch
from
985926e to
e3ad82d
Compare
|
/lgtm |
|
/lgtm |
|
@kononovn: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kononovn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
No description provided.