HOSTEDCP-1981: Add controlplane cli image envar for use with hypershift #2507
Conversation
|
@Patryk-Stefanski: This pull request references HOSTEDCP-1981 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
@Patryk-Stefanski: The
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest-required |
3 similar comments
|
/retest-required |
|
/retest-required |
|
/retest-required |
|
@Patryk-Stefanski: This pull request references HOSTEDCP-1981 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@dougbtv could you ptal. |
|
Can we do it the other way around to keep it consistent with the already existing OVN-K image approach? |
Patryk-Stefanski
force-pushed
the
HOSTEDCP-1981
branch
from
1d971d4 to
2ab159e
Compare
Patryk-Stefanski
changed the title
|
@Patryk-Stefanski: This pull request references HOSTEDCP-1981 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@kyrtapz done |
Patryk-Stefanski
changed the title
Add CLI_CONTROL_PLANE_IMAGE enavr to cloud-network, multus-admission-controller and node-identity to avoid registryOverrides propagating to data plane components
Patryk-Stefanski
force-pushed
the
HOSTEDCP-1981
branch
from
2ab159e to
9a56d23
Compare
|
/retest-required |
|
@Patryk-Stefanski: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kyrtapz, Patryk-Stefanski The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit 1773dcf
into
openshift:master
|
@Patryk-Stefanski once the HyperShift PR merges it might be a good idea to remove the if condition for this change to ensure we never end up using the wrong image unknowingly. |
|
[ART PR BUILD NOTIFIER] Distgit: cluster-network-operator |
|
/cherry-pick release-4.17 release-4.16 release-4.15 release-4.14 |
|
@Patryk-Stefanski: new pull request created: #2542 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Add CLI_CONTROL_PLANE_IMAGE enavr to
cloud-network, multus-admission-controller and node-identity to avoid
registryOverrides propagating to data plane components