Improve retry mechanism for IPsec certificate signing requests #2527
+162
−248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pperiyasamy
force-pushed
the
ipsec-csr-improve-retry
branch
from
3a65910 to
2c82759
Compare
|
/retest |
When CSR is not signed within a minute, ipsec pod is crashlooping and keeps creating CSR at a minute interval until it succeeds. This is not a scalable solution on 500 node setup because signer takes a while to sign the CSR. Hence this commit implements a linear backoff mechanism with initial delay of 5 minutes and maximum of 3 attempts. So this would avoid storming API server with lots of CSR requests. Signed-off-by: Periyasamy Palanisamy <pepalani@redhat.com>
pperiyasamy
force-pushed
the
ipsec-csr-improve-retry
branch
from
2c82759 to
ea934aa
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pperiyasamy The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@pperiyasamy: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When CSR is not signed within a minute, ipsec pod is crashlooping and keeps creating CSR at a minute interval until it succeeds. This is not a scalable solution on 500 node setup because signer takes a while to sign the CSR. Hence this commit implements a linear backoff mechanism with initial delay of 5 minutes and maximum of 3 attempts. So this would avoid storming API server with lots of CSR requests.