Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "iptables-alerter daemonset should run everywhere" #2588

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stbenjam
Copy link
Member

Reverts #2581

openshift/origin#29357 will allow the alert we're experiencing to fire on managed services until it resolves itself. Open tolerations in general are a bad idea (even if the platform allows it). See Dan's comment about the implications of my change #2581 (comment)

The iptables-alerter tolerations is less broken in its original state, so let's return it there.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 10, 2024
@stbenjam stbenjam changed the title Revert "OCPBUGS-45341: iptables-alerter daemonset should run everywhere" Revert "iptables-alerter daemonset should run everywhere" Dec 10, 2024
@openshift-ci-robot
Copy link
Contributor

@stbenjam: This pull request references Jira Issue OCPBUGS-45341, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Reverts #2581

openshift/origin#29357 will allow the alert we're experiencing to fire on managed services until it resolves itself. Open tolerations in general are a bad idea (even if the platform allows it). See Dan's comment about the implications of my change #2581 (comment)

The iptables-alerter tolerations is less broken in its original state, so let's return it there.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 10, 2024
@openshift-ci-robot
Copy link
Contributor

@stbenjam: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

Reverts #2581

openshift/origin#29357 will allow the alert we're experiencing to fire on managed services until it resolves itself. Open tolerations in general are a bad idea (even if the platform allows it). See Dan's comment about the implications of my change #2581 (comment)

The iptables-alerter tolerations is less broken in its original state, so let's return it there.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from jcaamano and trozet December 10, 2024 15:23
Copy link
Contributor

openshift-ci bot commented Dec 10, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stbenjam
Once this PR has been reviewed and has the lgtm label, please assign jcaamano for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stbenjam
Copy link
Member Author

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Dec 10, 2024
Copy link
Contributor

openshift-ci bot commented Dec 10, 2024

@stbenjam: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ovn-ipsec-step-registry b95b842 link false /test e2e-ovn-ipsec-step-registry
ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec b95b842 link false /test e2e-metal-ipi-ovn-ipv6-ipsec
ci/prow/e2e-aws-ovn-hypershift-conformance b95b842 link true /test e2e-aws-ovn-hypershift-conformance
ci/prow/security b95b842 link false /test security
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 b95b842 link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/okd-scos-e2e-aws-ovn b95b842 link false /test okd-scos-e2e-aws-ovn
ci/prow/4.18-upgrade-from-stable-4.17-e2e-azure-ovn-upgrade b95b842 link false /test 4.18-upgrade-from-stable-4.17-e2e-azure-ovn-upgrade
ci/prow/4.18-upgrade-from-stable-4.17-e2e-aws-ovn-upgrade b95b842 link false /test 4.18-upgrade-from-stable-4.17-e2e-aws-ovn-upgrade
ci/prow/e2e-aws-hypershift-ovn-kubevirt b95b842 link false /test e2e-aws-hypershift-ovn-kubevirt
ci/prow/e2e-aws-ovn-upgrade b95b842 link true /test e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-local-to-shared-gateway-mode-migration b95b842 link false /test e2e-aws-ovn-local-to-shared-gateway-mode-migration

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants