HIVE-2270: minimal e2e support for vSphere

[dlom]

xref: HIVE-2270

corresponding CI PR: openshift/release#64450

see also: #2541

/assign @2uasimojo

[openshift-ci-robot]

@dlom: This pull request references HIVE-2270 which is a valid jira issue.

In response to this:

xref: HIVE-2270

corresponding CI PR: openshift/release#64450

/assign @2uasimojo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@dlom: This pull request references HIVE-2270 which is a valid jira issue.

In response to this:

xref: HIVE-2270

corresponding CI PR: openshift/release#64450

/assign @2uasimojo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@dlom: This pull request references HIVE-2270 which is a valid jira issue.

In response to this:

xref: HIVE-2270

corresponding CI PR: openshift/release#64450

see also: #2541

/assign @2uasimojo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[dlom]

/test e2e-vsphere

[2uasimojo]

Yeah, seems legit. I'm happy if the job is happy.

(If it were me, I might not have bothered making hiveutil support the env var as well as the CLI flag, but it's cool.)

/lgtm

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.

Project coverage is 50.24%. Comparing base (d03ed3f) to head (2c213e9).
Report is 4 commits behind head on master.

Files with missing lines	Patch %	Lines
contrib/pkg/createcluster/create.go	0.00%	30 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2673      +/-   ##
==========================================
- Coverage   50.27%   50.24%   -0.04%     
==========================================
  Files         287      287              
  Lines       33949    33971      +22     
==========================================
  Hits        17069    17069              
- Misses      15531    15553      +22     
  Partials     1349     1349              

Files with missing lines	Coverage Δ
pkg/constants/constants.go	100.00% <ø> (ø)
contrib/pkg/createcluster/create.go	0.00% <0.00%> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD d03ed3f and 2 for PR HEAD fa49673 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD d03ed3f and 2 for PR HEAD fa49673 in total

[2uasimojo]

/lgtm cancel

looks like we're missing the vcenter input

[dlom]

/test e2e-vsphere

[openshift-ci]

@dlom: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[2uasimojo]

Yessss!

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo, dlom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [2uasimojo,dlom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment