Check manila Storage class before checking manila endpoint #212
Conversation
If manila storage class doesn't exist - skip the test. If it exists - check that the manila endpoint exists if not - fail
|
I'm ok with this. The manilaSC existance is a consequence of some checks that the manila controller is doing. So if it exists and the endpoint is not there...it's a bug. /lgtm |
|
@itzikb-redhat: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rlobillo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/cherry-pick release-4.18 release-4.17 release-4.16 |
|
@MiguelCarpio: new pull request created: #213 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
If manila storage class doesn't exist - skip the test. If it exists - check that the manila endpoint exists if not - fail