-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.17] Check manila Storage class before checking manila endpoint #214
[release-4.17] Check manila Storage class before checking manila endpoint #214
Conversation
If manila storage class doesn't exist - skip the test. If it exists - check that the manila endpoint exists if not - fail
/retest |
3 similar comments
/retest |
/retest |
/retest |
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/lgtm |
Could you point to a failed job so that we can verify it fixes an issue in CI? |
This update fixed the issue #213 was already merged and solved the problem, we don't have a specific failed job with this issue at the 4.17 release, however, the enhancement should be applied for all releases (we need to check the endpoint before running the test) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eurijon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f454dfa
into
openshift:release-4.17
@openshift-cherrypick-robot: new pull request created: #218 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This is an automated cherry-pick of #213
/assign openshift-cherrypick-robot
/cherrypick release-4.16