Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with installed multiple version of the OpenCL #276

Conversation

redradist
Copy link

@redradist redradist commented Feb 26, 2025

Description

This PR fix issue with multiple version OpenCL installed on machine as well as brings new versions of OpenCL 3_0

For details explanation of an issue with ${OPENCL_INCLUDE_DIR}/CL/cl.h https://stackoverflow.com/a/79347124/5157245

Similar PR was already merged in uxlfoundation#2378 and https://gitlab.kitware.com/cmake/cmake/-/merge_requests/10366, issue was more deeply investigated and PR was reworked

@redradist
Copy link
Author

redradist commented Feb 26, 2025

@dmitry-gorokhov Could someone to approve CI for this PR ?
Similar PR was already merged in uxlfoundation#2378 and https://gitlab.kitware.com/cmake/cmake/-/merge_requests/10366

@dmitry-gorokhov
Copy link
Collaborator

Thanks @redradist . Could you please answer this question first: #267 (comment) ?

@redradist
Copy link
Author

redradist commented Feb 27, 2025

Thanks @redradist . Could you please answer this question first: #267 (comment) ?

@dmitry-gorokhov Done

As for me it should not bother, because this changes are general and already merged in main CMake repository as well as in oneDNN main repository

@redradist
Copy link
Author

@dmitry-gorokhov Even thought this repo is used only for intel_cpu, this changes in this PR is general.
Consider it as synchronization with CMake and oneAPI versions

@dmitry-gorokhov
Copy link
Collaborator

We regurally migrate this fork on oneDNN release versions, Currently the fork is based on oneDNN v3.6, so once we update on v3,8 this patch will be automatically obtained from the upstream. I don't see any value in merging it before that.

@redradist redradist closed this Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants