Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update onednn submodule hash to fix 3D deconv post-ops issue. #11836

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

luweizhou2016
Copy link
Contributor

@luweizhou2016 luweizhou2016 commented Jun 8, 2022

Update onednn submodule hash to fix 3D deconv post-ops issue.

@luweizhou2016 luweizhou2016 requested review from a team as code owners June 8, 2022 23:05
@luweizhou2016 luweizhou2016 requested review from tomdol, ceciliapeng2011 and yeonbok and removed request for a team June 8, 2022 23:05
@luweizhou2016
Copy link
Contributor Author

@luweizhou2016 luweizhou2016 changed the title Update Update onednn submodule hash to fix 3D deconv post-ops issue. Jun 9, 2022
@tomdol
Copy link
Contributor

tomdol commented Jun 9, 2022

This looks like a direct edit of a file inside a submodule, this shouldn't be done like that. The submodule itself should be updated to a commit/tag which contains the required change.

@luweizhou2016
Copy link
Contributor Author

This looks like a direct edit of a file inside a submodule, this shouldn't be done like that. The submodule itself should be updated to a commit/tag which contains the required change.

The PR is to update based on this openvinotoolkit/oneDNN#130. Will refer to another PR next time. Thx

@usstq usstq merged commit 0066ddb into openvinotoolkit:master Jun 13, 2022
@luweizhou2016 luweizhou2016 deleted the luwei/fix_crash branch September 2, 2022 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants