[CPU] Enable mmap for model loading from cache. #23315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
category: inference
nshchego
force-pushed
the
cpu/compile_mmap
branch
3 times, most recently
from
a606c76 to
3b59467
Compare
github-actions
bot
added
category: GPU
maxnick
requested changes
Oct 7, 2024
|
@nshchego , could you please reply to the comment https://github.com/openvinotoolkit/openvino/pull/23315/files#r1706731713 ? |
Modified |
nshchego
force-pushed
the
cpu/compile_mmap
branch
from
04ed798 to
6131c71
Compare
nshchego
force-pushed
the
cpu/compile_mmap
branch
from
6131c71 to
d5961c5
Compare
nshchego
force-pushed
the
cpu/compile_mmap
branch
2 times, most recently
from
2665849 to
80f01ae
Compare
maxnick
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
In general LGTM, except the MmapStream usage as a container for ov::MappedMemory and the subsequent dynamic cast. Given the fact that the necessary interfaces are going to be introduced in the near future, this PR may be merged as an intermediate state, which allows to have certain speed up of loading models from cache. However, it should be agreed in which order this PR and #26696 should be merged.
nshchego
force-pushed
the
cpu/compile_mmap
branch
from
80f01ae to
aaff252
Compare
nshchego
force-pushed
the
cpu/compile_mmap
branch
from
3c8245f to
642d53c
Compare
nshchego
force-pushed
the
cpu/compile_mmap
branch
from
642d53c to
44ce367
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: