Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Py OV] Add deprecation warning for runtime module #27694

Merged
merged 17 commits into from
Jan 16, 2025

Conversation

almilosz
Copy link
Contributor

@almilosz almilosz commented Nov 22, 2024

Details:

Add deprecation warning for openvino.runtime that will be shown ONCE when sb will access runtime functionality for the first time. Examples:
Screenshot 2025-01-10 114701
warn_updated

openvino.runtime funtionality was added to openvino namespace in these PRs:

Internal calls in openvino module also triggered warning, so they were updated:

Tickets:

Signed-off-by: Alicja Miloszewska <alicja.miloszewska@intel.com>
Signed-off-by: Alicja Miloszewska <alicja.miloszewska@intel.com>
Signed-off-by: Alicja Miloszewska <alicja.miloszewska@intel.com>
Signed-off-by: Alicja Miloszewska <alicja.miloszewska@intel.com>
…ilosz/openvino into almilosz/lazy-import-warning

Signed-off-by: Alicja Miloszewska <alicja.miloszewska@intel.com>
Copy link
Contributor

github-actions bot commented Jan 5, 2025

This PR will be closed in a week because of 2 weeks of no activity.

@github-actions github-actions bot added the Stale label Jan 5, 2025
…into almilosz/lazy-import-warning

Signed-off-by: Alicja Miloszewska <alicja.miloszewska@intel.com>
Signed-off-by: Alicja Miloszewska <alicja.miloszewska@intel.com>
@almilosz almilosz marked this pull request as ready for review January 9, 2025 08:52
@almilosz almilosz requested review from a team as code owners January 9, 2025 08:52
@github-actions github-actions bot removed the Stale label Jan 10, 2025
@mlukasze
Copy link
Contributor

@rkazants please take a look from OVC perspective

@akuporos akuporos added this to the 2025.0 milestone Jan 13, 2025
@almilosz almilosz requested a review from rkazants January 13, 2025 12:51
@mlukasze
Copy link
Contributor

@rkazants friendly reminder, it's aimed for 25.0

@rkazants
Copy link
Contributor

Why there is no warning when you import AxisVector from openvino.runtime?

Copy link
Contributor

@rkazants rkazants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make tests to cover the following cases:

  1. import openvino; axis_vector = openvino.AxisVector([1, 2]) Test there is no warning and it is functional
  2. import openvino; axis_vector = openvino.runtime.AxisVector([1, 2]) Test it still functional and raise a warning. And test lazy loading
  3. import openvino.runtime as runtime; axis_vector = runtime.AxisVector([1, 2]) Test it still functional and raise a warning. And test lazy loading
  4. import openvino.runtime; import openvino.runtime.utils How many warnings shall we get one or two?

@almilosz
Copy link
Contributor Author

Why there is no warning when you import AxisVector from openvino.runtime?

The warning will be shown only once. If it was shown before AxisVector was used, then there will be no warning when importing AxisVector

…into almilosz/lazy-import-warning

Signed-off-by: Alicja Miloszewska <alicja.miloszewska@intel.com>
Signed-off-by: Alicja Miloszewska <alicja.miloszewska@intel.com>
Signed-off-by: Alicja Miloszewska <alicja.miloszewska@intel.com>
Signed-off-by: Alicja Miloszewska <alicja.miloszewska@intel.com>
Signed-off-by: Alicja Miloszewska <alicja.miloszewska@intel.com>
@almilosz almilosz requested a review from akuporos January 15, 2025 14:17
Signed-off-by: Alicja Miloszewska <alicja.miloszewska@intel.com>
@almilosz
Copy link
Contributor Author

@akuporos Please look one more time on the final version we prepared and it can be merged :)

@akuporos akuporos added this pull request to the merge queue Jan 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 15, 2025
@mlukasze mlukasze added this pull request to the merge queue Jan 16, 2025
Merged via the queue into openvinotoolkit:master with commit 2b442b4 Jan 16, 2025
185 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: OVC OVC tool category: Python API OpenVINO Python bindings category: tools OpenVINO C++ / Python tools Code Freeze
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants