-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Py OV] Add deprecation warning for runtime module #27694
[Py OV] Add deprecation warning for runtime module #27694
Conversation
Signed-off-by: Alicja Miloszewska <alicja.miloszewska@intel.com>
Signed-off-by: Alicja Miloszewska <alicja.miloszewska@intel.com>
Signed-off-by: Alicja Miloszewska <alicja.miloszewska@intel.com>
Signed-off-by: Alicja Miloszewska <alicja.miloszewska@intel.com>
…ilosz/openvino into almilosz/lazy-import-warning Signed-off-by: Alicja Miloszewska <alicja.miloszewska@intel.com>
This PR will be closed in a week because of 2 weeks of no activity. |
…into almilosz/lazy-import-warning Signed-off-by: Alicja Miloszewska <alicja.miloszewska@intel.com>
Signed-off-by: Alicja Miloszewska <alicja.miloszewska@intel.com>
@rkazants please take a look from OVC perspective |
@rkazants friendly reminder, it's aimed for 25.0 |
Why there is no warning when you import |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please make tests to cover the following cases:
- import openvino; axis_vector = openvino.AxisVector([1, 2]) Test there is no warning and it is functional
- import openvino; axis_vector = openvino.runtime.AxisVector([1, 2]) Test it still functional and raise a warning. And test lazy loading
- import openvino.runtime as runtime; axis_vector = runtime.AxisVector([1, 2]) Test it still functional and raise a warning. And test lazy loading
- import openvino.runtime; import openvino.runtime.utils How many warnings shall we get one or two?
The warning will be shown only once. If it was shown before |
…into almilosz/lazy-import-warning Signed-off-by: Alicja Miloszewska <alicja.miloszewska@intel.com>
Signed-off-by: Alicja Miloszewska <alicja.miloszewska@intel.com>
Signed-off-by: Alicja Miloszewska <alicja.miloszewska@intel.com>
Signed-off-by: Alicja Miloszewska <alicja.miloszewska@intel.com>
@akuporos Please look one more time on the final version we prepared and it can be merged :) |
Details:
Add deprecation warning for
openvino.runtime
that will be shown ONCE when sb will access runtime functionality for the first time. Examples:openvino.runtime
funtionality was added to openvino namespace in these PRs:Internal calls in
openvino
module also triggered warning, so they were updated:Tickets: