Fix for coverity issues of medium and low impact #27916

AsyaPronina · 2024-12-04T16:44:19Z

Details:

Fixed "Data race condition" (Medium), "COPY_INSTEAD_OF_MOVE" and "Use of auto that causes a copy" (Low) issues
...

Tickets:

EISW-149544

dmatveev · 2024-12-04T19:54:50Z

src/plugins/intel_npu/src/plugin/npuw/weights_bank.cpp

    auto npu_bank = m_device_banks.find("NPU");
    if (npu_bank != m_device_banks.end() && npu_bank->second.storage.find(tensor) != npu_bank->second.storage.end()) {


storage lock should've been taken here too.

### Details: - *Fixed "Data race condition" (Medium) Coverity issue* - *Mirrored part of #27916 ### Tickets: - *EISW-149544*

AsyaPronina requested review from a team as code owners December 4, 2024 16:44

github-actions bot added category: NPU OpenVINO NPU plugin category: NPUW NPUW plugin labels Dec 4, 2024

Fix for coverity issue of medium impact: Possible data race

fdaf610

AsyaPronina force-pushed the fix_npuw_medium_and_low_impact_coverity branch from b961530 to fdaf610 Compare December 4, 2024 17:00

Fixed low prio Coverity issues

f73dbe3

AsyaPronina changed the title ~~Fix for coverity issue of medium impact: Possible data race~~ Fix for coverity issue of medium and low impact Dec 4, 2024

AsyaPronina changed the title ~~Fix for coverity issue of medium and low impact~~ Fix for coverity issues of medium and low impact Dec 4, 2024

AsyaPronina mentioned this pull request Dec 4, 2024

Fix for coverity issue of medium impact: Possible data race #27918

Merged

smirnov-alexey approved these changes Dec 4, 2024

View reviewed changes

AsyaPronina enabled auto-merge December 4, 2024 18:04

AsyaPronina added this pull request to the merge queue Dec 4, 2024

dmatveev reviewed Dec 4, 2024

View reviewed changes

dmatveev removed this pull request from the merge queue due to a manual request Dec 4, 2024

Fixed according review comments

5b318a3

dmatveev approved these changes Dec 5, 2024

View reviewed changes

dmatveev added this pull request to the merge queue Dec 5, 2024

Merged via the queue into openvinotoolkit:master with commit 07ecdf0 Dec 5, 2024
157 checks passed

dmatveev deleted the fix_npuw_medium_and_low_impact_coverity branch December 5, 2024 01:43

github-merge-queue bot pushed a commit that referenced this pull request Dec 5, 2024

Fix for coverity issue of medium impact: Possible data race (#27918)

f6c3cec

### Details: - *Fixed "Data race condition" (Medium) Coverity issue* - *Mirrored part of #27916 ### Tickets: - *EISW-149544*

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix for coverity issues of medium and low impact #27916

Fix for coverity issues of medium and low impact #27916

AsyaPronina commented Dec 4, 2024 •

edited

Loading

dmatveev Dec 4, 2024

		auto npu_bank = m_device_banks.find("NPU");
		if (npu_bank != m_device_banks.end() && npu_bank->second.storage.find(tensor) != npu_bank->second.storage.end()) {

Fix for coverity issues of medium and low impact #27916

Fix for coverity issues of medium and low impact #27916

Conversation

AsyaPronina commented Dec 4, 2024 • edited Loading

Details:

Tickets:

dmatveev Dec 4, 2024

Choose a reason for hiding this comment

AsyaPronina commented Dec 4, 2024 •

edited

Loading