-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GPU] fix memory conflict for multi iteration in loop. #28056
Closed
+252,824
−113,373
Closed
Changes from 3 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
317f8a6
copy memory when input shape change on single_shared
timxu826 85a95ce
prune redundent codes
timxu826 1cc9af1
Merge branch 'master' into cvs_158017
timxu826 d83c8b6
Merge branch 'master' into cvs_158017
timxu826 164ebea
changed the dynamic input from single_shared to single
timxu826 071cdfa
Merge remote-tracking branch 'refs/remotes/origin/cvs_158017' into cv…
timxu826 4244dcb
fix loop shape change
timxu826 a9a6d04
Revert "changed the dynamic input from single_shared to single"
timxu826 6dc130d
Revert "Merge remote-tracking branch 'refs/remotes/origin/cvs_158017'…
timxu826 ef7fe71
Revert "changed the dynamic input from single_shared to single"
timxu826 0522d88
Revert "prune redundent codes"
timxu826 cf70410
Merge branch 'cvs_158017_c' into cvs_158017
timxu826 9b88f45
revert "copy memory when input shape change on single_shared"
timxu826 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this check condition creates redundant memory copies in cases where there is no memory conflict.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timxu826 From the description, you seem to resolve memory conflicts issue?
If so, is this enough?
Shouldn't we prevent memory reuse for the problematic case?