Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CPU] oneDNN3.6 cherry-pick backports #28843

Merged
merged 1 commit into from
Feb 11, 2025
Merged

[CPU] oneDNN3.6 cherry-pick backports #28843

merged 1 commit into from
Feb 11, 2025

Conversation

azhai219
Copy link
Contributor

@azhai219 azhai219 commented Feb 6, 2025 •
edited by dmitry-gorokhov
Loading

test onednn branch is https://github.com/openvinotoolkit/oneDNN/tree/xiuchuan/dev-v3.6
but without permission of pushing cherry-pick commits to branch https://github.com/openvinotoolkit/oneDNN/tree/v3.6_for_ie_master

oneDNN fork PR: openvinotoolkit/oneDNN#273

@azhai219 azhai219 requested review from a team as code owners February 6, 2025 05:49
@azhai219 azhai219 marked this pull request as draft February 6, 2025 05:49
@github-actions github-actions bot added the category: CPU OpenVINO CPU plugin label Feb 6, 2025
@azhai219 azhai219 added no_stale Do not mark as stale do_not_merge and removed category: CPU OpenVINO CPU plugin labels Feb 6, 2025
@azhai219 azhai219 changed the title oneDNN3.6 cherry-pick backports [CPU] oneDNN3.6 cherry-pick backports Feb 6, 2025
@github-actions github-actions bot added the category: CPU OpenVINO CPU plugin label Feb 7, 2025
@azhai219 azhai219 marked this pull request as ready for review February 7, 2025 05:26
@dmitry-gorokhov
Copy link
Contributor

@xczhai Please rebase you PR as it now has a conflict

@dmitry-gorokhov dmitry-gorokhov added this to the 2025.1 milestone Feb 10, 2025
@dmitry-gorokhov dmitry-gorokhov self-assigned this Feb 10, 2025
@dmitry-gorokhov
Copy link
Contributor

So I think we now can enable BF16 output for Int8 Matmul on OV side (and maybe there are some other feature unblocked).
Are there any plans to do that? Separate PR?

@azhai219
oneDNN3.6 cherry-pick backports
172dbcb 
- fix the copy_a init in brgemm
- relax the gru tests
@azhai219 azhai219 removed the no_stale Do not mark as stale label Feb 11, 2025
@azhai219 azhai219 force-pushed the az/dnn36_cherry_pick branch from fdf0ba1 to 172dbcb Compare February 11, 2025 03:29
@azhai219
Copy link
Contributor Author

@xczhai Please rebase you PR as it now has a conflict

update the PR.

@azhai219
Copy link
Contributor Author

azhai219 commented Feb 11, 2025 •
edited
Loading

So I think we now can enable BF16 output for Int8 Matmul on OV side (and maybe there are some other feature unblocked). Are there any plans to do that? Separate PR?

Have not received the request. Could you help create one? @dmitry-gorokhov

@dmitry-gorokhov dmitry-gorokhov added this pull request to the merge queue Feb 11, 2025
@dmitry-gorokhov
Copy link
Contributor

So I think we now can enable BF16 output for Int8 Matmul on OV side (and maybe there are some other feature unblocked). Are there any plans to do that? Separate PR?

Have not received the request. Could you help create one? @dmitry-gorokhov

Should be part of https://jira.devtools.intel.com/browse/CVS-152168. @liubo-intel Has more details

Merged via the queue into openvinotoolkit:master with commit d55a720 Feb 11, 2025
181 checks passed
@dmitry-gorokhov dmitry-gorokhov deleted the az/dnn36_cherry_pick branch February 11, 2025 08:40
AJThePro99 pushed a commit to AJThePro99/openvino that referenced this pull request Feb 11, 2025
@azhai219 @AJThePro99
[CPU] oneDNN3.6 cherry-pick backports (openvinotoolkit#28843)
2250a7d 
- fix the copy_a init in brgemm:
uxlfoundation/oneDNN@59513f7
- relax the rnn tests

test onednn branch is
https://github.com/openvinotoolkit/oneDNN/tree/xiuchuan/dev-v3.6
but without permission of pushing cherry-pick commits to branch
https://github.com/openvinotoolkit/oneDNN/tree/v3.6_for_ie_master

oneDNN fork PR: openvinotoolkit/oneDNN#273
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitry-gorokhov dmitry-gorokhov

Assignees

@dmitry-gorokhov dmitry-gorokhov

Labels
category: CPU OpenVINO CPU plugin
Projects
None yet
Milestone
2025.1
Development

Successfully merging this pull request may close these issues.
3 participants
@azhai219 @dmitry-gorokhov @yuxu42