Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CPU] Apply 'readability-implicit-bool-conversion' clang-tidy remarks #29218

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[CPU] Apply 'readability-implicit-bool-conversion' clang-tidy remarks #29218

wants to merge 4 commits into from
+146 −149

Conversation

aobolensk
Copy link
Contributor

@aobolensk aobolensk commented Feb 28, 2025 •
edited
Loading

Details:

  • Fix "readability-implicit-bool-conversion" remarks reported by clang-tidy
  • Enable "readability-implicit-bool-conversion" clang-tidy checks on CI by default
  • Modify its options by allowing integer and pointer conditions: AllowIntegerConditions and AllowPointerConditions

Tickets:

  • N/A

@aobolensk aobolensk requested review from a team as code owners February 28, 2025 17:00
@github-actions github-actions bot added the category: CPU OpenVINO CPU plugin label Feb 28, 2025
@aobolensk aobolensk force-pushed the readability-implicit-bool-conversion branch 2 times, most recently from da9560c to 4a358b4 Compare March 3, 2025 13:02
@aobolensk aobolensk marked this pull request as draft March 3, 2025 14:33
@aobolensk aobolensk force-pushed the readability-implicit-bool-conversion branch from 15f90a2 to 0dfd36c Compare March 4, 2025 11:26
@aobolensk aobolensk force-pushed the readability-implicit-bool-conversion branch 3 times, most recently from c596127 to 9106f2f Compare March 12, 2025 17:19
@aobolensk aobolensk marked this pull request as ready for review March 12, 2025 18:02
@aobolensk aobolensk force-pushed the readability-implicit-bool-conversion branch from 9106f2f to a739676 Compare March 31, 2025 15:18
EgorDuplensky
EgorDuplensky reviewed Apr 2, 2025
View reviewed changes
src/plugins/intel_cpu/src/emitters/plugin/x64/utils.cpp
@@ -37,7 +37,7 @@ struct regs_to_spill {
static std::vector<Xbyak::Reg> get(const std::set<snippets::Reg>& live_regs) {
std::vector<Xbyak::Reg> regs_to_spill;
auto push_if_live = [&live_regs, &regs_to_spill](Xbyak::Reg&& reg) {
if (live_regs.empty() || live_regs.count(Xbyak2SnippetsReg(reg))) {
if (live_regs.empty() || (live_regs.count(Xbyak2SnippetsReg(reg)) != 0u)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please double check the changes with respect to the relaxed requirements.
The best way probably would be to reapply them from scratch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-applied it from scratch. It seems this is covered in any case.

@aobolensk aobolensk force-pushed the readability-implicit-bool-conversion branch 3 times, most recently from 674c90d to cc0bd43 Compare April 2, 2025 15:34
EgorDuplensky
EgorDuplensky reviewed Apr 4, 2025
View reviewed changes
src/plugins/intel_cpu/src/nodes/topk.cpp Outdated
@@ -2460,11 +2460,11 @@ void TopK::calc_dims_size(const VectorDims& layout_dims) {
void TopK::topk_ref(const float* in_ptr, float* out_ptr, int32_t* dst_idx) {
if (mode_max) {
topk_ref_process(in_ptr, out_ptr, dst_idx, src_dims, [](float x, float y) -> float {
return x > y;
return static_cast<float>(x > y);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's change the return type to 'bool'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed

src/plugins/intel_cpu/src/node.cpp Outdated
@@ -108,11 +108,11 @@ Node::Node(const std::shared_ptr<ov::Node>& op, GraphContext::CPtr ctx, const Sh
}

const auto& rtInfo = op->get_rt_info();
if (rtInfo.count("originalLayersNames")) {
if (rtInfo.count("originalLayersNames") != 0u) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just remove the check?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, done

src/plugins/intel_cpu/src/node.cpp Outdated
@@ -1218,10 +1218,10 @@ void Node::toNumaNodeImpl(int numaNodeID) {
}

// mbind constant prim args to numa nodes
if (primArgs.count(DNNL_ARG_WEIGHTS)) {
if (primArgs.count(DNNL_ARG_WEIGHTS) != 0u) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's replace with std::find here and below if possible

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done for all cases where it is applicable

@aobolensk aobolensk force-pushed the readability-implicit-bool-conversion branch from cc0bd43 to 8458e7f Compare April 4, 2025 13:19
@aobolensk aobolensk assigned maxnick and unassigned EgorDuplensky Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EgorDuplensky EgorDuplensky EgorDuplensky left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@maxnick maxnick

Labels
category: CPU OpenVINO CPU plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aobolensk @EgorDuplensky @maxnick