[GPU] update onednn with the latest rls-v3.8-pc #29256
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sungeunk
force-pushed
the
update_onednn_25ww10_rls3.8pc
branch
from
70fa7cf to
d999379
Compare
sungeunk
changed the title
sungeunk
force-pushed
the
update_onednn_25ww10_rls3.8pc
branch
from
dd00f0d to
bb90467
Compare
| add_library(onednn_gpu_tgt INTERFACE) | ||
| set_target_properties(onednn_gpu_tgt PROPERTIES | ||
| INTERFACE_LINK_LIBRARIES $<BUILD_INTERFACE:${ONEDNN_GPU_LIB_PATH}> | ||
| INTERFACE_INCLUDE_DIRECTORIES "$<BUILD_INTERFACE:${LIB_INCLUDE_DIRS}>" | ||
| INTERFACE_SYSTEM_INCLUDE_DIRECTORIES "${LIB_INCLUDE_DIRS}" | ||
| INTERFACE_COMPILE_DEFINITIONS "${LIB_DEFINITIONS}" | ||
| ) | ||
| INTERNAL_INCLUDE_DIRECTORIES "${LIB_INTERNAL_INCLUDE_DIRS}" |
There was a problem hiding this comment.
Seems like custom properties must also be prefixed with INTERFACE_ to avoid error for rhel
sungeunk
force-pushed
the
update_onednn_25ww10_rls3.8pc
branch
from
d84db9c to
9181a91
Compare
vpirogov
reviewed
Mar 11, 2025
| @@ -56,7 +56,8 @@ if(OV_COMPILER_IS_INTEL_LLVM) | |||
| endif() | |||
|
|
|||
| if(ENABLE_ONEDNN_FOR_GPU) | |||
| ov_target_link_libraries_as_system(${TARGET_NAME} PUBLIC onednn_gpu_tgt) | |||
| ov_target_link_libraries_as_system(${TARGET_NAME} PRIVATE onednn_gpu_tgt) | |||
| target_include_directories(${TARGET_NAME} SYSTEM PRIVATE $<TARGET_PROPERTY:onednn_gpu_tgt,INTERFACE_INTERNAL_INCLUDE_DIRECTORIES>) | |||
There was a problem hiding this comment.
This change puts headers from onednn/third_party in front of all other headers. Why is this necessary?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.