Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added aten::take, aten::str and aten::Delete, but unable to write their tests #29479

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

vijaykr338
Copy link

@vijaykr338 vijaykr338 commented Mar 15, 2025

Details:

I was able to implement aten::take and aten::Delete function,

but aten::str posed really high difficult, i was only able to partially implement the it

currently, my implementation works for constant tensors, but for dynamic tensors, it currently stores shape and dtype for later use in debugging.

I have another question, how do you write tests for functions which are not implemented in Aten library yet?

I was able to write test cases for aten::take by following examples existing pytest files in the PyTorch layer tests folder.

but when I did the same for Delete and str, they consistently gave error

this is my first contribution to openVINO, I would greatly appreciate any guidance or assistance.

Tickets:

@vijaykr338 vijaykr338 requested a review from a team as a code owner March 15, 2025 05:15
@github-actions github-actions bot added the category: PyTorch FE OpenVINO PyTorch Frontend label Mar 15, 2025
@sys-openvino-ci sys-openvino-ci added the ExternalPR External contributor label Mar 15, 2025
@vijaykr338 vijaykr338 marked this pull request as draft March 15, 2025 10:47
@vijaykr338 vijaykr338 changed the title added aten::take function in pytorch FE, tests are not running [WIP] added aten::take, aten::str and aten::Delete, but unable to write their tests Mar 15, 2025
@vijaykr338 vijaykr338 marked this pull request as ready for review March 15, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: PyTorch FE OpenVINO PyTorch Frontend ExternalPR External contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants