[ONNX] Extended frontend for ReduceL1 for opset 11,13, 18 #29499
+93
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mohame54 thanks for your contribution, looks good, let's check! |
|
@mohame54 could you fix small code style errors? |
|
thank you for the review I 'm solving them right now |
gkrivor
reviewed
Mar 20, 2025
| @@ -276,6 +279,10 @@ ov::OutputVector reduce_l2(const Node& node) { | |||
| return {make_ov_reduction_op<v4::ReduceL2>(node, node.get_ov_inputs().at(0), supported_types_v2, false)}; | |||
| } | |||
|
|
|||
| ov::OutputVector reduce_l1(const None& node){ | |||
There was a problem hiding this comment.
Looks like it exists, but not registered :(
There was a problem hiding this comment.
yeah, I noticed but thank you though
|
Made the changes you asked from me @gkrivor and I will wait for your feedbacks thank you |
|
@gkrivor can you plz recheck my pull request |
gkrivor
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets:
Closes: #20559