[tools][sit] Add U8 clamp to NPU SIT #29592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
category: Core
HongyuWangIntel
force-pushed
the
hongyu/u8_clamp
branch
from
70246a2 to
1906ff9
Compare
github-actions
bot
removed
category: Core
HongyuWangIntel
changed the title
|
Hi, could you please take a look? @ArtemySkrebkov @DariaMityagina @Maxim-Doronin |
| @@ -97,6 +97,7 @@ DEFINE_string(data_shape, "", | |||
| "In case of one input size: \"[1,3,224,224]\""); | |||
| DEFINE_string(skip_output_layers, "" , "Skip output layers from the network. Currently only applicable for" | |||
| "RRMSE and NRMSE mode. Accept ';' separated list of output layers"); | |||
| DEFINE_bool(clamp_u8, false, "Apply clamping when convert fp to u8 to make models like edsr work correctly."); | |||
There was a problem hiding this comment.
We shouldn't mention specific networks.
Suggested change
| DEFINE_bool(clamp_u8, false, "Apply clamping when convert fp to u8 to make models like edsr work correctly."); | |
| DEFINE_bool(clamp_u8, false, "Apply clamping when converting FP to U8"); |
There was a problem hiding this comment.
Fixed in 384f801
| @@ -259,6 +260,7 @@ void parseCommandLine(int argc, char* argv[]) { | |||
| std::cout << " Mean_values [channel1,channel2,channel3] " << FLAGS_mean_values << std::endl; | |||
| std::cout << " Scale_values [channel1,channel2,channel3] " << FLAGS_scale_values << std::endl; | |||
| std::cout << " Skip checking output layers: " << FLAGS_skip_output_layers << std::endl; | |||
| std::cout << " Clamp u8 output: " << FLAGS_clamp_u8 << std::endl; | |||
There was a problem hiding this comment.
We should have a more explicit name for the option, if it's only for output:
Suggested change
| std::cout << " Clamp u8 output: " << FLAGS_clamp_u8 << std::endl; | |
| std::cout << " Clamp U8 outputs: " << FLAGS_clamp_u8_outputs << std::endl; |
There was a problem hiding this comment.
Fixed in 384f801
HongyuWangIntel
force-pushed
the
hongyu/u8_clamp
branch
from
1906ff9 to
384f801
Compare
|
build_jenkins |
ArtemySkrebkov
approved these changes
Apr 2, 2025
Maxim-Doronin
approved these changes
Apr 3, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: