Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PyOV][WIP] Add GHA action to validate .pyi files in pre-commit #29888

Open
wants to merge 71 commits into
base: master
Choose a base branch
from
Open

[PyOV][WIP] Add GHA action to validate .pyi files in pre-commit #29888

wants to merge 71 commits into from
+977 −701

Conversation

p-wysocki
Copy link
Contributor

Details:

  • WIP, exploration on if we can easily use GHA instead of adding the check to CMake

Tickets:

p-wysocki added 2 commits April 2, 2025 11:56
@p-wysocki
Add test to GHA
f8294d5 
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
@p-wysocki
Merge branch 'master' of https://github.com/openvinotoolkit/openvino …
20d9dc3 
…into pyi_cmake_check

Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
@p-wysocki p-wysocki added this to the 2025.2 milestone Apr 2, 2025
@p-wysocki p-wysocki requested review from a team as code owners April 2, 2025 09:58
@github-actions github-actions bot added category: Python API OpenVINO Python bindings category: CI OpenVINO public CI github_actions Pull requests that update GitHub Actions code labels Apr 2, 2025
p-wysocki added 6 commits April 2, 2025 12:56
@p-wysocki
Update paths
1b36e04 
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
@p-wysocki
Checkout new action
a88f7b4 
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
@p-wysocki
sparse checkout pyapi scripts
652a55b 
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
@p-wysocki
Correct sparse checkout
d22694b 
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
@p-wysocki
Debug prints
ff362e0 
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
@p-wysocki
Try using INSTALL_TEST_DIR
346173c 
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
@github-actions github-actions bot removed the category: Python API OpenVINO Python bindings label Apr 3, 2025
p-wysocki added 10 commits April 3, 2025 14:54
@p-wysocki
Debug
e0d973b 
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
@p-wysocki
Remove faulty line
cc68d0f 
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
@p-wysocki
Update action
e8c1af3 
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
@p-wysocki
Debug changes
3907cca 
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
@p-wysocki
Modify sparse-checkout
a84a05c 
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
@p-wysocki
Debug
5eb67a8 
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
@p-wysocki
Debug
006c8b5 
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
@p-wysocki
List all checkedout files
77a20cd 
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
@p-wysocki
Correct the paths
4481a53 
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
@p-wysocki
Modify the file discovery on CI
c54f690 
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
@github-actions github-actions bot added the category: Python API OpenVINO Python bindings label Apr 6, 2025
p-wysocki added 2 commits April 6, 2025 13:36
@p-wysocki
Fix mistake
0f1c4e2 
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
@p-wysocki
Sparse checkout sh script explicitly
41d6392 
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
p-wysocki added 18 commits April 8, 2025 13:42
@p-wysocki
Trigger .pyi regen
80cc5b2 
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
@p-wysocki
Cleanup
9efcace 
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
@p-wysocki
Modify comparison logic
309c8e7 
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
@p-wysocki
Temporary change to warning
6d35fe9 
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
@p-wysocki
Add new comparison logic
6e771dd 
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
@p-wysocki
Add new comparison logic
597d47e 
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
@p-wysocki
Apply changes in comparison
6767089 
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
@p-wysocki
Don't evaluate empty diff list
e03d318 
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
@p-wysocki
Check generator emptiness, more debug info
271638b 
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
@p-wysocki
Omit the Committed: <file_path> diff line from comparison
0e6e340 
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
@p-wysocki
Ignore diff-specific line with ---
54f10e8 
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
@p-wysocki
Add SKIPS
3c79881 
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
@p-wysocki
Ignore __all__ diffs
7ef3dc5 
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
@p-wysocki
Merge branch 'master' into pyi_cmake_check
cf5321c
@p-wysocki
Update rules for skips
a774ee5 
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
@p-wysocki
Minor change
e384005 
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
@p-wysocki
Ignore extra identation
c72b8be 
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
@p-wysocki
Ignore empty newlines
646207c 
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
p-wysocki added 11 commits April 10, 2025 13:43
@p-wysocki
Move to a Python script
2f73484 
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
@p-wysocki
Remove temp files
6a16788 
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
@p-wysocki
Change ext
e0a9af1 
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
@p-wysocki
Minor change
76b636e 
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
@p-wysocki
Add arg to gen script
c0a6cbd 
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
@p-wysocki
Fix .pyi file
6f96b77 
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
@p-wysocki
lstrip for pyi
7d1317a 
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
@p-wysocki
Omit triple quotes as well
8cda9ef 
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
@p-wysocki
Ensure the line is not empty after stripping
0aec0c9 
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
@p-wysocki
Also remove triple quotes
14c9016 
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
@p-wysocki
Cosmetic change
f9d4231 
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
category: build OpenVINO cmake script / infra category: CI OpenVINO public CI category: Python API OpenVINO Python bindings category: TF FE OpenVINO TensorFlow FrontEnd do_not_merge do_not_review github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
2025.2
Development

Successfully merging this pull request may close these issues.
1 participant
@p-wysocki