Skip to content

[GPU] smaller range of indices for gather elements in test #30094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[GPU] smaller range of indices for gather elements in test #30094

wants to merge 3 commits into from
+26 −5

Conversation

michal-miotk
Copy link
Contributor

Details:

  • previously gather indices was generated by default in full range of int32 which was besides dimension at given axis(most frequently axis dimension was 20, so indices should be in range 0-19) ; generated values was even below zero.

Tickets:

  • 164932

@michal-miotk michal-miotk requested review from a team as code owners April 11, 2025 18:29
@github-actions github-actions bot added the category: GPU OpenVINO GPU plugin label Apr 11, 2025
@michal-miotk michal-miotk changed the title [GPU] normal range of gather elements in test [GPU] smaller range of gather elements in test Apr 11, 2025
@michal-miotk michal-miotk changed the title [GPU] smaller range of gather elements in test [GPU] smaller range of indices for gather elements in test Apr 11, 2025
sshlyapn
sshlyapn reviewed Apr 14, 2025
View reviewed changes
src/plugins/intel_gpu/tests/functional/single_layer_tests/gather_elements_padding_input.cpp Outdated
if (funcInput.get_element_type().is_real()) {
ov::test::utils::InputGenerateData in_data;
in_data.start_from = 0;
in_data.range = 10;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to use original dimension size here, can it be obtained from GatherElements input?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sshlyapn sshlyapn sshlyapn left review comments

@p-durandin p-durandin p-durandin approved these changes

Assignees
No one assigned
Labels
category: GPU OpenVINO GPU plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michal-miotk @sshlyapn @p-durandin