Revise swish #5983
Merged
Revise swish #5983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openvino-pushbot
added
ExternalIntelPR
|
@lazarevevgeny , can you pls help to review the patches? Thanks! |
ilyachur
approved these changes
Jun 8, 2021
lazarevevgeny
approved these changes
Jun 8, 2021
|
Tag with "DONOT MERGE". Will Update this PR after #6181 is merged first. Aviod duplicate code. |
|
Please resolve merge conflicts |
Signed-off-by: Luwei Zhou <luwei.zhou@intel.com>
Add input element type check when constructing Swish OP. Signed-off-by: Luwei Zhou <luwei.zhou@intel.com>
Signed-off-by: Luwei Zhou <luwei.zhou@intel.com>
Signed-off-by: Luwei Zhou <luwei.zhou@intel.com>
Signed-off-by: Luwei Zhou <luwei.zhou@intel.com>
Signed-off-by: Luwei Zhou <luwei.zhou@intel.com>
Signed-off-by: Luwei Zhou <luwei.zhou@intel.com>
luweizhou2016
force-pushed
the
revise_swish
branch
from
7f51f99 to
15227af
Compare
|
CI issue is caused by auto merging changes the MKLDNN submodule unexpectly. I have rebased the code and cherry pick the patch. CI issue fixed. |
rnugmanx
pushed a commit
to rnugmanx/openvino
that referenced
this pull request
Aug 26, 2021
* Update Swish OP description. Signed-off-by: Luwei Zhou <luwei.zhou@intel.com> * Use RTTI to declare/define NGraph Swish OP. Add input element type check when constructing Swish OP. Signed-off-by: Luwei Zhou <luwei.zhou@intel.com> * Add Swish into activation serialization test list. Signed-off-by: Luwei Zhou <luwei.zhou@intel.com> * Add Swish into IE CPU plugin activation single layer test suit. Signed-off-by: Luwei Zhou <luwei.zhou@intel.com> * Add Swish NGraph backend and visitor API tests. Signed-off-by: Luwei Zhou <luwei.zhou@intel.com> * Add Swish unsupported parameter data type test cases. Signed-off-by: Luwei Zhou <luwei.zhou@intel.com> * Update the Swish OP visistor API to use typed test. Signed-off-by: Luwei Zhou <luwei.zhou@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Add description into Swish spec.
Add more check when constructing Swish OP in NGraph.
Change to use RTTI declear/define for Swish OP.
Add type prop , visitor (attributes), SSLT, backend , serialization tests for Swish OP.
Tickets:
37560