Add jersey server jakarta module #1458
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@codefromthecrypt - Would appreciate a review. Happy to accommodate any changes or alternative approaches too |
There was a problem hiding this comment.
The approach follows others like JMS. Basically @reta and/or I need to second eye review nothing was missed in the find/replace adjustment
| <parent> | ||
| <groupId>io.zipkin.brave</groupId> | ||
| <artifactId>brave-instrumentation-parent</artifactId> | ||
| <version>6.1.1-SNAPSHOT</version> |
There was a problem hiding this comment.
We need to bump all poms to 6.2.0-SNAPSHOT and verify the since javadoc on public types are since 6.2
reta
reviewed
Apr 8, 2025
Co-authored-by: Andriy Redko <drreta@gmail.com>
| ### Normal configuration (`TracingApplicationEventListener`) | ||
|
|
||
| The `TracingApplicationEventListener` requires an instance of | ||
| `HttpTracing` to operate. With that in mind, use [standard means](https://jersey.github.io/apidocs/2.26/jersey/org/glassfish/jersey/server/monitoring/ApplicationEventListener.html) |
There was a problem hiding this comment.
this link needs an update, too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A copy of jersey-server module to work with jakarta namespace. There are references to javax classes like WebApplicationException in the jersey-server module