Skip to content

Conversation

BidyadharM
Copy link
Contributor

Description

Fixes the issue where the alias name is getting identified when quoted and provided as:
DB.Table(""table" "alias"").

Type of change

Added a before callback for Query(), that checks the TableExp and applies the reg-ex that identifies table name alias when quoted.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • TestPreloadWithConds

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Aug 20, 2025
oracle/query.go Outdated
)

// Identifies the table name alias provided as
// "\"users\" \"u\"". Gorm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the blank lines

shelly-li-sl
shelly-li-sl previously approved these changes Aug 21, 2025
@norah-li norah-li mentioned this pull request Aug 21, 2025
@BidyadharM BidyadharM force-pushed the prefix-fix branch 3 times, most recently from de90b96 to d0f63e6 Compare August 27, 2025 14:02
ting-lan-wang
ting-lan-wang previously approved these changes Aug 27, 2025
@ting-lan-wang ting-lan-wang merged commit baadd6e into main Aug 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants