Skip to content

Conversation

ting-lan-wang
Copy link
Contributor

@ting-lan-wang ting-lan-wang commented Aug 21, 2025

Description

This PR removes the unused passed-tests.txt file.
This PR also enables more tests that were skipped previously probably because of the quoting issues, including:

  • TestCreateWithAssociations
  • TestBulkCreatePtrDataWithAssociations
  • TestJoins
  • TestJoinsForSlice
  • TestJoinConds
  • TestJoinOn
  • TestInnerJoins
  • TestJoinArgsWithDB
  • TestMixedSaveBatch

Lastly, fixes TestScanToEmbedded, TestUseDBInHooks and TestExceptionsWithInvalidSql.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Aug 21, 2025
@ting-lan-wang ting-lan-wang changed the title Tinglwan fix miscellaneous tests Fix miscellaneous tests, and remove passed-tests.txt Aug 21, 2025
shelly-li-sl
shelly-li-sl previously approved these changes Aug 21, 2025
@shelly-li-sl
Copy link
Contributor

TestScanToEmbedded failed in the run-tests results. Could you please check?

@ting-lan-wang ting-lan-wang self-assigned this Aug 26, 2025
@ting-lan-wang ting-lan-wang marked this pull request as draft August 26, 2025 16:52
@ting-lan-wang ting-lan-wang changed the title Fix miscellaneous tests, and remove passed-tests.txt Fix miscellaneous tests Aug 26, 2025
@ting-lan-wang ting-lan-wang marked this pull request as ready for review August 29, 2025 21:23
@ting-lan-wang ting-lan-wang merged commit 223c0e9 into main Aug 29, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants