Skip to content

Migrate nullable fix #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 29, 2025
Merged

Migrate nullable fix #38

merged 5 commits into from
Aug 29, 2025

Conversation

jawad-arb123
Copy link
Member

PR Description

  • Skips ALTER TABLE if:
    • The type and nullability already match.
    • The change would be unsafe (nullable → non-nullable).
  • Allows safe changes:
    • Non-nullable → nullable (e.g., NOT NULL → NULL).
    • Type changes (e.g., VARCHAR(100) → VARCHAR(255)).

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Aug 22, 2025
@jawad-arb123
Copy link
Member Author

Running all the Tests. Still in Progress!

shelly-li-sl
shelly-li-sl previously approved these changes Aug 22, 2025
View reviewed changes
@jawad-arb123
Merge branch 'main' into migrate_nullable_fix
c67cb43 
# Conflicts:
#	tests/passed-tests.txt
@jawad-arb123 jawad-arb123 merged commit f49a090 into main Aug 29, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ting-lan-wang ting-lan-wang ting-lan-wang approved these changes

@aarrasseayoub01 aarrasseayoub01 aarrasseayoub01 left review comments

@shelly-li-sl shelly-li-sl shelly-li-sl left review comments

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jawad-arb123 @ting-lan-wang @aarrasseayoub01 @shelly-li-sl