Skip to content

LandingPage: Add Edge decommission alert (HMS-6156) #3210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ochosi
Copy link
Contributor

@ochosi ochosi commented May 9, 2025

This alert will only be shown when the 'immutable' tab has focus.
Below are screenshots of both tabs.

image
image

This will likely require further work after UX mockups are complete/ready. E.g. do we want to use this alert type? Is the copy correct/complete?

@ochosi ochosi added the 🍼 simple Simple and quick to review label May 9, 2025
@ochosi ochosi force-pushed the edge-decommission-banner branch from e8834eb to ea51f4f Compare May 9, 2025 08:28
Copy link

codecov bot commented May 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.66%. Comparing base (efed39d) to head (0f202d4).

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3210      +/-   ##
==========================================
+ Coverage   84.65%   84.66%   +0.01%     
==========================================
  Files         187      187              
  Lines       23491    23507      +16     
  Branches     2455     2455              
==========================================
+ Hits        19886    19902      +16     
  Misses       3586     3586              
  Partials       19       19              
Files with missing lines Coverage Δ
...Components/sharedComponents/ImageBuilderHeader.tsx 97.76% <100.00%> (+0.30%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efed39d...0f202d4. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@regexowl regexowl force-pushed the edge-decommission-banner branch from ea51f4f to 51d90e2 Compare May 9, 2025 09:20
Copy link
Collaborator

@regexowl regexowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! ❤️ Is this still a draft/blocked by something? Happy to merge when ready.

@ochosi
Copy link
Contributor Author

ochosi commented May 9, 2025

@regexowl TY ❤️
It's a draft mostly because the UX mockups didn't seem final and we're unsure when to publish this, I think

@ochosi
Copy link
Contributor Author

ochosi commented May 12, 2025

Update: This is scheduled to land on May 30, so I'll keep it a draft until then.

This alert will only be shown when the 'immutable' tab has focus.
@ochosi ochosi force-pushed the edge-decommission-banner branch from 51d90e2 to 0f202d4 Compare May 22, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍼 simple Simple and quick to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants