Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the hypervisor_type for all images to qemu #783

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Conversation

berendt
Copy link
Member

@berendt berendt commented Apr 12, 2024

This also removes the hypervisor CLI parameter. It makes no sense to change the hypervisor for all images as the hypervisor is defined for each image.

@berendt berendt requested a review from mbuechse April 12, 2024 08:20
@berendt berendt force-pushed the set-hypervisor-type branch from f83617f to d7f2892 Compare April 12, 2024 08:28
Copy link
Contributor

@mbuechse mbuechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't verify that you caught every image, but apart from that, it looks good to me (50 cents into the platitudes box)

This also removes the hypervisor CLI parameter. It makes no sense to
change the hypervisor for all images as the hypervisor is defined for
each image.

Signed-off-by: Christian Berendt <berendt@osism.tech>
@berendt berendt force-pushed the set-hypervisor-type branch from d7f2892 to 9e1e36a Compare April 15, 2024 07:48
@berendt berendt merged commit 30ad361 into main Apr 15, 2024
3 checks passed
@berendt berendt deleted the set-hypervisor-type branch April 15, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants