Skip to content

refactor(transformer/legacy-decorator): eliminate unreliable identification of metadata #13227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Aug 20, 2025

Fixes: #13215 (review)

Collect metadata and store them in a VecDeque, and take them when transforming the class decorators in the exit_class side, which can eliminate the unreliable check of span.is_unspanned for metadata decorators

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Aug 20, 2025
Copy link
Member Author

Dunqing commented Aug 20, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dunqing Dunqing changed the title refactor(transformer/decorator): eliminate unreliable identification of metadata refactor(transformer/legacy-decorator): eliminate unreliable identification of metadata Aug 20, 2025
Copy link

codspeed-hq bot commented Aug 20, 2025

CodSpeed Instrumentation Performance Report

Merging #13227 will not alter performance

Comparing 08-20-refactor_transformer_decorator_eliminate_unreliable_identification_of_metadata (3c27130) with main (d27a04b)1

Summary

✅ 34 untouched benchmarks

Footnotes

  1. No successful run was found on main (e84ae8b) during the generation of this report, so d27a04b was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@Dunqing Dunqing force-pushed the 08-20-refactor_transformer_decorator_eliminate_unreliable_identification_of_metadata branch from 16f8e20 to 3c27130 Compare August 20, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant