Skip to content

feat(formatter): complete printing TaggedTemplateExpression and TemplateLiteral #13247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 24, 2025
Merged

feat(formatter): complete printing TaggedTemplateExpression and TemplateLiteral #13247

merged 1 commit into from
Aug 24, 2025
+792 −99

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Aug 21, 2025

No description provided.

@github-actions github-actions bot added A-formatter Area - Formatter C-enhancement Category - New feature or request labels Aug 21, 2025
This was referenced Aug 21, 2025
Merged
Merged
Merged
@Dunqing Graphite App
Copy link
Member Author

Dunqing commented Aug 21, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dunqing Dunqing mentioned this pull request Aug 21, 2025
Merged
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Aug 21, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #13247 will not alter performance

Comparing 08-21-feat_formatter_complete_printing_taggedtemplateexpression_and_templateliteral (ebaebe4) with main (cae222c)1

Summary

✅ 34 untouched benchmarks

Footnotes

  1. No successful run was found on main (ebaebe4) during the generation of this report, so cae222c was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@Dunqing Dunqing force-pushed the 08-21-feat_formatter_complete_printing_taggedtemplateexpression_and_templateliteral branch from d4f161c to 0d682b8 Compare August 21, 2025 12:12
@github-actions github-actions bot added the A-ast-tools Area - AST tools label Aug 21, 2025
@Dunqing Dunqing force-pushed the 08-21-feat_formatter_complete_printing_taggedtemplateexpression_and_templateliteral branch 3 times, most recently from 3974c0f to abf9a83 Compare August 21, 2025 15:14
@Dunqing Dunqing mentioned this pull request Aug 21, 2025
Merged
@Dunqing Dunqing force-pushed the 08-21-feat_formatter_complete_printing_taggedtemplateexpression_and_templateliteral branch from abf9a83 to 9299508 Compare August 22, 2025 09:35
@Dunqing Dunqing force-pushed the 07-29-feat_formatter_complete_printing_staticmemberexpression branch from 1930fc0 to 9531160 Compare August 22, 2025 09:35
This was referenced Aug 22, 2025
Merged
Merged
@Dunqing Dunqing marked this pull request as ready for review August 24, 2025 00:15
@Dunqing Dunqing requested a review from overlookmotel as a code owner August 24, 2025 00:15
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Aug 24, 2025
@graphite-app Graphite App
Copy link
Contributor

graphite-app bot commented Aug 24, 2025 •
edited
Loading

Merge activity

Boshen
Boshen requested changes Aug 24, 2025
View reviewed changes
Copy link
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a huge performance regression.

@graphite-app graphite-app bot changed the base branch from 07-29-feat_formatter_complete_printing_staticmemberexpression to graphite-base/13247 August 24, 2025 03:33
@Dunqing
Copy link
Member Author

Dunqing commented Aug 24, 2025

There's a huge performance regression.

Codspeed got the wrong data to compare. The performance regression comes from #13112, not from this PR

@Dunqing Dunqing force-pushed the 08-21-feat_formatter_complete_printing_taggedtemplateexpression_and_templateliteral branch from 9299508 to f34d7c6 Compare August 24, 2025 03:37
@Dunqing Dunqing force-pushed the graphite-base/13247 branch from 9531160 to 2a21d1b Compare August 24, 2025 03:37
@Dunqing Dunqing changed the base branch from graphite-base/13247 to 07-29-feat_formatter_complete_printing_staticmemberexpression August 24, 2025 03:37
Base automatically changed from 07-29-feat_formatter_complete_printing_staticmemberexpression to main August 24, 2025 03:40
@Dunqing Dunqing force-pushed the 08-21-feat_formatter_complete_printing_taggedtemplateexpression_and_templateliteral branch from f34d7c6 to 2436cab Compare August 24, 2025 04:12
@Dunqing
Copy link
Member Author

Dunqing commented Aug 24, 2025

CodSpeed Instrumentation Performance Report

Merging #13247 will not alter performance

Comparing 08-21-feat_formatter_complete_printing_taggedtemplateexpression_and_templateliteral (2436cab) with main (2a21d1b)

Summary

✅ 34 untouched benchmarks

It looks correct now.

@Copilot Copilot AI review requested due to automatic review settings August 24, 2025 08:28
@graphite-app graphite-app bot force-pushed the 08-21-feat_formatter_complete_printing_taggedtemplateexpression_and_templateliteral branch from 2436cab to ebaebe4 Compare August 24, 2025 08:28
Copilot
Copilot AI reviewed Aug 24, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@graphite-app graphite-app bot merged commit ebaebe4 into main Aug 24, 2025
24 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 24, 2025
@graphite-app graphite-app bot deleted the 08-21-feat_formatter_complete_printing_taggedtemplateexpression_and_templateliteral branch August 24, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@Boshen Boshen Boshen approved these changes

@overlookmotel overlookmotel Awaiting requested review from overlookmotel overlookmotel is a code owner

Assignees
No one assigned
Labels
A-ast-tools Area - AST tools A-formatter Area - Formatter C-enhancement Category - New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dunqing @Boshen