Add support for Docker aliases #493
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanhu
force-pushed
the
sh-alias-gnu-builds
branch
from
86a6068 to
7b8dfb3
Compare
stanhu
commented
Jan 16, 2025
| - ruby_target: x64-mingw32 | ||
| - ruby_target: x64-mingw-ucrt | ||
| # - ruby_target: x86-linux | ||
| toolchain: ${{ fromJSON(needs.fetch_ci_data.outputs.toolchains-data) }} |
There was a problem hiding this comment.
This will include x86-linux again; do we want to omit it?
There was a problem hiding this comment.
if it builds, i'm ok with it! there was an issue before breaking builds :/
stanhu
force-pushed
the
sh-alias-gnu-builds
branch
4 times, most recently
from
68ba67e to
1fd942d
Compare
|
I think this is working, though https://github.com/oxidize-rb/rb-sys/actions/runs/12818599166/job/35744460713?pr=494 is failing because the tag has a leading |
stanhu
commented
Jan 16, 2025
stanhu
force-pushed
the
sh-alias-gnu-builds
branch
2 times, most recently
from
51be4be to
ddbeb51
Compare
rake-compiler-dock now makes a clear distinction between GNU and Musl builds: https://github.com/rake-compiler/rake-compiler-dock?tab=readme-ov-file#linux-gnu-and-musl-important-details This change makes it possible to build images using the explicit aarch64-linux-gnu and x86_64-linux-gnu targets needed by rake-compiler-dock.
stanhu
force-pushed
the
sh-alias-gnu-builds
branch
from
ddbeb51 to
8b61115
Compare
|
In https://github.com/oxidize-rb/rb-sys/actions/runs/12819077576/job/35745982383?pr=494, you can see the In https://github.com/oxidize-rb/rb-sys/actions/runs/12819077576/job/35745984135?pr=494, you can see the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rake-compiler-dock now makes a clear distinction between GNU and Musl builds:
https://github.com/rake-compiler/rake-compiler-dock?tab=readme-ov-file#linux-gnu-and-musl-important-details
This change makes it possible to build images using the explicit aarch64-linux-gnu and x86_64-linux-gnu targets needed by rake-compiler-dock.