Merge wormhole contracts+history into palomadex #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Good review feedback from Leo
* Add some unit-test coverage for GuardianSet * Remove mu check to fix CI run * Remove unnecessary copy paste
commit-id:12c98920
It appears this is needed to get a local devnet working.
* Testnet support * Upgrade contract for 1conf * Formatting changes Change-Id: Id06481d77d770a04eb200aadb82574e23cddcd36
The type of the `ix_data` binding withing the solitaire! macro expansion is explicitly annotated with its type, which comes from the macro's pattern binding `$kind`. However, this type annotation is entirely optional, since `ix_data` is passed in as an argument to `$fn`, whose type forecs `ix_data` anyway, and rust will happily infer that from the application. So we remove the explicit annotation which makes the entry point macro easier to use. commit-id:d428306c
* explorer animations & fixes * fix breakpoint
* bridge_ui: Make transfers to/from chains configurable
Updated ethers dependency
This mostly looks like deleting everything we do not want to fork.
It is unmaintained and Uint256 is preferred within the cosmwasm ecosystem.
|
I am curious what are the negative consequences of this approach? If we don't use Wormhole, will this be an issue? |
|
@taariq I think absolute worst case we can delete the directory. There are a couple ways to get the effect I'm going for here, but this is about the most organized way I can think of to have our wormhole depend on terraswap/astroport. |
Vizualni
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
palomachain/paloma#177
Background
Rather than continue to fragment the volume contract repos I would like to merge them into a monorepo.
Large single-workspace rust projects are a good way of managing lockstep dependencies. In particular
the "astroport", previously "terraswap" dependency is shared between DEX and wormhole.
Testing completed