BUG: Fix #61221: Exception with unstack(sort=False) and NA in index. #61226
+138
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Apr 4, 2025
| tm.assert_frame_equal(left, right, check_dtype=False) | ||
|
|
||
|
|
||
| def test_unstack_sort_false_na(): |
There was a problem hiding this comment.
If there's multiple test cases here, it's best to split each assertion to it's own test.
mroeschke
requested changes
Apr 4, 2025
| @@ -1605,6 +1605,110 @@ def test_stack_sort_false(future_stack): | |||
| tm.assert_frame_equal(result, expected) | |||
|
|
|||
|
|
|||
| def assert_na_safe_equal(left, right): | |||
There was a problem hiding this comment.
We shouldn't need this function. Ideally the same NA values should be in the input and output
There was a problem hiding this comment.
yea, thats to my own failures, I couldn't figure out how to create a dataframe with values as they just got converted into Nan. If you know how to create the proper dataframe for the expected, I can remove that.
Do you have any tips on how i can properly create the expected DF?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unstack(sort=False)and NA in index #61221doc/source/whatsnew/v3.0.0.rstfile if fixing a bug or adding a new feature.