Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try fixing occasional freeze on request processing. #265

Open
wants to merge 1 commit into
base: 2.0
Choose a base branch
from
Open

Try fixing occasional freeze on request processing. #265

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
100 changes: 54 additions & 46 deletions src/RawRabbit/Channel/ChannelFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,68 +188,76 @@ private void EnsureRequestsAreHandled()
_processingRequests = true;
_logger.Debug("Begining to process 'GetChannel' requests.");
}

TaskCompletionSource<IModel> channelTcs;
while (_requestQueue.TryDequeue(out channelTcs))
try
{
if (channelTcs.Task.IsCanceled)
{
continue;
}
lock (_channelLock)
TaskCompletionSource<IModel> channelTcs;
while (_requestQueue.TryDequeue(out channelTcs))
{
if (_current == null && _channelConfig.InitialChannelCount == 0)
if (channelTcs.Task.IsCanceled)
{
CreateAndWireupAsync().Wait();
_current = _channels.First;
}
_current = _current.Next ?? _channels.First;

if (_current.Value.IsOpen)
{
channelTcs.TrySetResult(_current.Value);
continue;
}

_logger.Info("Channel '{channelNumber}' is closed. Removing it from pool.", _current.Value.ChannelNumber);
_channels.Remove(_current);

if (_current.Value.CloseReason.Initiator == ShutdownInitiator.Application)
lock (_channelLock)
{
_logger.Info("Channel '{channelNumber}' is closed by application. Disposing channel.", _current.Value.ChannelNumber);
_current.Value.Dispose();
if (!_channels.Any())
if (_current == null && _channelConfig.InitialChannelCount == 0)
{
CreateAndWireupAsync().Wait();
_current = _channels.First;
}
_current = _current.Next ?? _channels.First;

if (_current.Value.IsOpen)
{
var newChannelTask = CreateAndWireupAsync();
newChannelTask.Wait();
_current = _channels.Last;
channelTcs.TrySetResult(_current.Value);
continue;
}

_logger.Info("Channel '{channelNumber}' is closed. Removing it from pool.", _current.Value.ChannelNumber);
_channels.Remove(_current);

if (_current.Value.CloseReason.Initiator == ShutdownInitiator.Application)
{
_logger.Info("Channel '{channelNumber}' is closed by application. Disposing channel.",
_current.Value.ChannelNumber);
_current.Value.Dispose();
if (!_channels.Any())
{
var newChannelTask = CreateAndWireupAsync();
newChannelTask.Wait();
_current = _channels.Last;
channelTcs.TrySetResult(_current.Value);
continue;
}
}
}
}

var openChannel = _channels.FirstOrDefault(c => c.IsOpen);
if (openChannel != null)
{
_logger.Info("Using channel '{channelNumber}', which is open.", openChannel.ChannelNumber);
channelTcs.TrySetResult(openChannel);
continue;
}
var isRecoverable = _channels.Any(c => c is IRecoverable);
if (!isRecoverable)
{
var openChannel = _channels.FirstOrDefault(c => c.IsOpen);
if (openChannel != null)
{
_logger.Info("Using channel '{channelNumber}', which is open.", openChannel.ChannelNumber);
channelTcs.TrySetResult(openChannel);
continue;
}
var isRecoverable = _channels.Any(c => c is IRecoverable);
if (!isRecoverable)
{
_processingRequests = false;
throw new ChannelAvailabilityException(
"Unable to retreive channel. All existing channels are closed and none of them are recoverable.");
}

_logger.Info(
"Unable to find an open channel. Requeue TaskCompletionSource for future process and abort execution.");
_requestQueue.Enqueue(channelTcs);
_processingRequests = false;
throw new ChannelAvailabilityException("Unable to retreive channel. All existing channels are closed and none of them are recoverable.");
return;
}

_logger.Info("Unable to find an open channel. Requeue TaskCompletionSource for future process and abort execution.");
_requestQueue.Enqueue(channelTcs);
}
finally
{
_processingRequests = false;
return;
_logger.Debug("'GetChannel' has been processed.");
}
_processingRequests = false;
_logger.Debug("'GetChannel' has been processed.");
}

public async Task<IModel> CreateChannelAsync(CancellationToken token = default(CancellationToken))
Expand Down