fix!: make smoldot discovery interface conform to smoldot interface #2516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 08c0883 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ryanleecode
force-pushed
the
fix/smoldot-discovery1
branch
from
936a9ae to
f00258f
Compare
ryanleecode
changed the title
ryanleecode
force-pushed
the
fix/smoldot-discovery1
branch
4 times, most recently
from
a0fbe3c to
59d43d1
Compare
ryanleecode
force-pushed
the
fix/smoldot-discovery1
branch
8 times, most recently
from
3bf116f to
e1a65af
Compare
ryanleecode
force-pushed
the
fix/smoldot-discovery1
branch
from
e1a65af to
08c0883
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing smoldot interface wasnt compatible to the actual smoldot interface, so we couldnt use
smProvider.This change removes the "jsonRpcCallback" from
addChainand just exposesnextJsonRpcResponseandjsonRpcResponses, just like smoldot does.