Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add playout delay extension support #1152

Merged
merged 5 commits into from
Apr 24, 2024
Merged

Add playout delay extension support #1152

merged 5 commits into from
Apr 24, 2024

Conversation

sbarrac
Copy link
Contributor

@sbarrac sbarrac commented Apr 1, 2024

Adds support for the playout delay extension

@sbarrac
Copy link
Contributor Author

sbarrac commented Apr 10, 2024

Just thought I'd add some context.

This extension is really useful for cloud gaming scenarios. I was having an issue where the browser (chrome) would try to make the video smoother by delaying the rendering of a H264 stream. Even with ~10ms latency and zero packet loss, it was delaying the rendering by ~40MS, which is a huge delay in the context of playing a streamed game.

The playout delay extension with minimum & maximum playout set to zero was the only way I found to remove this delay.

Copy link
Owner

@paullouisageneau paullouisageneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, I'm only concerned about the header size in the packetizer.

sbarrac and others added 2 commits April 19, 2024 20:47
Co-authored-by: Paul-Louis Ageneau <paul-louis@ageneau.org>
@sbarrac
Copy link
Contributor Author

sbarrac commented Apr 19, 2024

I think this is ready.

I've tested with different min/max values and it's working as expected. Debug output also shows no issues.

Copy link
Owner

@paullouisageneau paullouisageneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, thank you!

@paullouisageneau paullouisageneau merged commit fcebd6d into paullouisageneau:master Apr 24, 2024
12 checks passed
@paullouisageneau paullouisageneau changed the title Added playout delay extension support Add playout delay extension support Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants