-
-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add playout delay extension support #1152
Conversation
Just thought I'd add some context. This extension is really useful for cloud gaming scenarios. I was having an issue where the browser (chrome) would try to make the video smoother by delaying the rendering of a H264 stream. Even with ~10ms latency and zero packet loss, it was delaying the rendering by ~40MS, which is a huge delay in the context of playing a streamed game. The playout delay extension with minimum & maximum playout set to zero was the only way I found to remove this delay. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good, I'm only concerned about the header size in the packetizer.
Co-authored-by: Paul-Louis Ageneau <paul-louis@ageneau.org>
I think this is ready. I've tested with different min/max values and it's working as expected. Debug output also shows no issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good, thank you!
Adds support for the playout delay extension